fix: enable custom model selection for Claude Code provider#1229
fix: enable custom model selection for Claude Code provider#1229pujan-modha wants to merge 2 commits intopingdotgg:mainfrom
Conversation
- Allow threads to be created without a hardcoded model (model is now nullable) - Defer provider binding to first turn instead of thread creation, so users can switch to custom models (MiniMax, etc.) before sending their first message - Fix GUI app authentication by reading API credentials from ~/.claude/settings.json - Enable skills loading from settings.json via settingSources: ["user"] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can validate your CodeRabbit configuration file in your editor.If your editor has YAML language server, you can enable auto-completion and validation by adding |
github-actions
bot
added
size:L
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Replace raw JSON.parse with Effect.try and Schema.decodeUnknownSync in getClaudeEnvFromSettings to align with Effect platform patterns used elsewhere in the codebase (e.g., Identify.ts). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
What Changed
~/.claude/settings.jsonsettings.jsonviasettingSources: ["user"]Why
Threads were previously hardcoded to
gpt-5-codexat creation, preventing users from selecting custom models like MiniMax, GLM, etc. Additionally, provider binding happened at thread creation which rejected any different model on the first turn.This fix defers provider binding to the first turn, allowing users to explicitly select their desired model and provider before the session is bound. The fix also ensures GUI apps can authenticate properly and load skills from the user's settings.
Checklist
Note
Enable custom model selection for the Claude Code provider on first turn
ProviderCommandReactorare now enforced only after a session exists; first turns can specify a provider or model that differs from the thread's configured model.isKnownModelSlugto model.ts to validate model slugs per provider; unknown slugs on first turn are not forwarded to the SDK.projection_threads.modelnullable via a new DB migration (016) and updates related schemas in contracts and persistence layers.process.envwith environment variables sourced from~/.claude/settings.jsonwhen invoking the Claude Agent SDK in ClaudeAdapter.ts.model = nullwhen no project default model exists.Macroscope summarized 594b628.